search

YuliangXiu / ECON

[CVPR'23, Highlight] ECON: Explicit Clothed humans Optimized via Normal integration
https://xiuyuliang.cn/econ
Other
1.08k stars 106 forks source link

About positional embedding #31

Closed Mors20 closed 1 year ago

Mors20 commented 1 year ago

Hi, thanks for your excellent work. As the paper saying, “the positional embedding (N freqs = 6) of query points is concatenated with multi-scale deep features to account for high-frequency details. '' I don't find positional embedding part in the Code. So I would like to know where this part of code is? Thanks!

YuliangXiu commented 1 year ago

To save GPU memory, I finally removed the PE module from Li et al.[1] but forgot to update the arXiv's appendix. Will correct it in the next version of arXiv, thanks so much for pointing out.

If you want to give a try to see the difference, you can still find it from sharp2022.

[1] Li L, Liu Z, Ren W, et al. 3D textured shape recovery with learned geometric priors[J]. arXiv preprint arXiv:2209.03254, 2022.

Mors20 commented 1 year ago

Thanks very much