search

Yummygum / city-lights-ui-atom

65 stars 15 forks source link

Avoid targeting `::before` in tab-pane styling #40

Closed Alhadis closed 6 years ago

Alhadis commented 6 years ago

This PR solves a styling conflict with the file-icons package, which uses ::before to display icons in file tabs. Currently, the tab-icons are missing because City Lights is replacing the pseudo-element with a bright blue bar.

This issue is easily remedied by using ::after instead.

Resolves file-icons/atom#745.

noudadrichem commented 6 years ago

Thank you for submitting a PR, i'll take a look at it.

Alhadis commented 6 years ago

Thanks!

noudadrichem commented 6 years ago

😊