New Zealand flag seems broken

Yummygum / flagpack-core

Flagpack contains 250+ flag icons to easily use within your code project.

https://flagpack.xyz

MIT License

576 stars 131 forks source link

New Zealand flag seems broken #62

Open Titou325 opened 2 years ago

Titou325 commented 2 years ago

Please check all that apply

[x] visual bug
[ ] functional bug
[x] able to consistently reproduce

Expected Behavior

The New Zealand flag should have a red cross in its top left corner.

Current Behavior

The New Zealand flag is missing its red cross.

This is also the case in this repository

Possible Solution

Add the red cross.

Thanks a lot for this package!

daoneandonly commented 2 years ago

Seems to me there is a masking issue with certain flags. I'll collect his and related issues here in as a single issue.

daoneandonly commented 2 years ago

As with #72 , the masking within some flag SVG seem to cause some visual bugs and potentially breaking bugs within react-native.

Found in Flags

NZ
CI

If you have found this only appear in certain sizes, feel free to share any of these insights.

SimpleCreations commented 2 years ago

@daoneandonly The same issue can also be found in:

HR
KR

DCzajkowski commented 1 year ago

Croatian (HR) flag as mentioned by @SimpleCreations looks different on the landing page and different in the index. Both seem to have masking issues and scaling is wrong.

Tested on mobile Safari and iOS 16.0.3 webview

7B7E5ED4-CD3F-4D1D-8D47-92B31C860BC6 06ACE9DF-BB3D-4F14-AA19-F0C6DB90EACD

kylegordy commented 1 year ago

I've been working from the Figma Flag Pack, and these render bugs don't appear there from what I can tell. The New Zealand flag is how we stumbled upon this issue too.

Is there something in the build step, like a file size optimizer, that might be causing these render bugs? I've had issues like that happen before.