search

Yummygum / flagpack-core

Flagpack contains 250+ flag icons to easily use within your code project.
https://flagpack.xyz
MIT License
576 stars 131 forks source link

Add missing flags - BQ, MC, XK #76

Closed RubyHuntsman closed 2 years ago

RubyHuntsman commented 2 years ago

I wanted to migrate from flag-country-react, but the package is missing three flags, so I can't do that. Any chance of adding the flags below?

Missing flags: Bonaire, Saint Eustatius and Saba - BQ Monaco - MC Kosovo - XK

daoneandonly commented 2 years ago

Hi @RubyHuntsman 👋 thanks for your sharing your thoughts!

The Caribbean Netherlands doesn't have a unique flag. Instead they use the flag of The Netherlands. Alternatively, we've chosen to include the individual flags of this islands. These can be found under the alpha2 codes BQ-BO, BQ-SA and BQ-SE respectively.

The flag of Monaco be found under the following alpha2, alpha3 and numeric values: MC, MCO, 492. Refer to our Flag Index to find the appropriate values for these flags.

Kosovo is not unfortunately not part the ISO 3166-1 standard we use to determine country codes and therefore we've opted not to include it in flagpack.

If you feel like your issues isn't resolved with this answer or have any more thoughts or comments, feel free to reopen this issue.

SimpleCreations commented 2 years ago

Hi @daoneandonly! Is there any particular reason not to include the flag of Kosovo other than the ISO standard?

I see how it's not a part of it, however I also don't see how including it is detrimental to the DX. On the contrary, as many developers need the flag of Kosovo, I can only see how adding it can benefit them, and those who (for some reason) don't need it, can just opt out of importing it or instantiating the flag component.

Furthermore, the flag of Kosovo is included in 1.x (which I reverted to as of now), so this is also a regression.