search

Yummygum / flagpack-core

Flagpack contains 250+ flag icons to easily use within your code project.
https://flagpack.xyz
MIT License
573 stars 130 forks source link

No flag for Algeria. #91

Open hasnatfahim12 opened 1 year ago

hasnatfahim12 commented 1 year ago

There seems to be no flag for the country Algeria. Algeria is the biggest country in Africa and the 10th biggest overall (by area). So Algeria should have a flag.

I believe it would benefit everyone using this and specially those who are creating product for the African continent.

areeb111 commented 1 year ago

+1 I would suggest to add it please.

zoeyfrisart commented 1 year ago

Hey, Thank you for creating this issue. The flag of Algeria is actually in Flagpack (https://github.com/Yummygum/flagpack-core/blob/main/svg/l/DZ.svg). I checked, and I see it is not in our documentation. I have not tested whether you can use the flag in the codebase, but I have passed this issue forward to the team.

Appologies for the delay in Response, I missed this issue in my Inbox until @areeb111 Responded. I hope to get back to you by the end of the week.

areeb111 commented 1 year ago

Thank you @zoeyfrisart , Actually i tried to use that in vue-flagpack with no chance, I believe it's missing here too countryCodeList.ts and types as well

zoeyfrisart commented 1 year ago

~In that case it's most likely missing from the sheet we use to generate the types and exports, I hope to look at this and release a fix sometime in the upcoming weeks.~

Edit, it appears to be in the file, I'll have to do some further investigating

flpalves commented 4 months ago

In the file "src/countryCodeList.ts" there is no information about Algeria.

Would adding this file solve the bug?