Yummygum / react-flagpack

Flagpack contains 250+ flag icons to easily use within your code project.
https://flagpack.xyz
MIT License
136 stars 28 forks source link

Broken release 1.1.0 #40

Closed lewis-fidlers closed 4 months ago

lewis-fidlers commented 3 years ago

Please check all that apply

Current Behavior

When Installed through npm install react-flagpack --save

Possible Solution

Seems like 1.1.0 was released yesterday, which is not tagged as the current release. It is installed through npm though when no version is specified.

So the easy fix is probably not making the 1.x branches available for now :)

Steps to Reproduce

  1. npx create-react-app my-app
  2. npm i react-flagpack
  3. add jsx <Flag code="NL" gradient="real-linear" size="m" hasDropShadow /> to the clean app
  4. a empty flag is shown: image
mrzlab630 commented 3 years ago

same problem

andrepadeti commented 3 years ago

same here as well

daoneandonly commented 3 years ago

Thanks for noting this issue. I've been working on a fix for this but this required some drastic changes. See #42 for more details. Also, if you have any thoughts regarding this let us know, possibly here or on our discussion regarding tree-shaking.

daoneandonly commented 3 years ago

While we still have some issues with react-flagpack, I've tested the latest build with an create-react-app and it rendered a Flag correctly. Can you confirm this issue has been solved?

zoeyfrisart commented 4 months ago

Hi all, this should now be resolved, in case you're still facing issues after upgrading to Version 2.0.2, please open up a new issue 🙏