Yummypets / YPImagePicker

📸 Instagram-like image picker & filters for iOS
MIT License
4.32k stars 976 forks source link

Preview clips non-square images #622

Open moltovivo opened 3 years ago

moltovivo commented 3 years ago

Describe the bug After selecting multiple images from the library, they are displayed in the preview screen all as squares. Even if the isSquareByDefault is false. So photos which should be in portrait orientation are clipped at their top and bottom edges. The main problem with this is it can give the user the misleading impression that their photo has been cropped, before they upload it to the app.

To Reproduce Steps to reproduce the behavior:

  1. Enable multiple selection
  2. Select 2+ images in Library. (Portrait images correctly display as portrait in the Library -- e.g. screenshots). Tap Next.
  3. The Preview screen now shows all the images as squares, and portrait images are clipped at their top and bottom edges.

Expected behavior Would expect the Preview screen to show images in a similar way to how they are shown in the Library. E.g. Portrait images in full size and correct aspect ratio, rather than squares. It can give the user the misleading impression that their photo has been cropped.

Screenshots (see attached - original image , Library and Preview) 3 2 1

Environment (please complete the following information): iphone 8, ios14 - tested on others in Simulator with same behavior

Installation Type

NullYing commented 5 months ago

I have the same problem.