YunaBraska / github-workflow-plugin

Your Ultimate Wingman for GitHub Workflows and Actions! 🚀
https://github.com/YunaBraska/github-workflow-plugin
Apache License 2.0
45 stars 10 forks source link

Allow developing composite actions within its own repository #15

Closed SimonSchwendele closed 1 year ago

SimonSchwendele commented 1 year ago

Description

I'm currently developing a lot of composite actions which should be used across a variety of repositories. This plugin however is currently only activated whenever the yml file resides in .github/workflows/*.yml

Background

You can push a composite action into its own repository and reference it like this

      - name: Do stuff with composite action
        uses: Owner/repo@branch
        with:
           input1: 'thing'
           input2: 'otherThing'

which means Im pushing repositories like this:

$ ls -a
.  ..  action.yml  .git   .gitignore  .idea
$ tree
.
└── action.yml

1 directory, 1 file

Request

This Plugin should recognize the existence of a compsite action

YunaBraska commented 1 year ago

Nice to know. I will have a look on this.

YunaBraska commented 1 year ago

Just to be sure that I understand this right...

Usecases

1) Local GitHub actions:

How are these two use cases connected? Or do you have a multimodule project?

SimonSchwendele commented 1 year ago

Okay there exists a private repository that contains the composite action image

When I use that action in my actual workflows I can use the Intellisense quite well.' image

However!

The request here is that I can't use the plugin during development. When I clone the repository in the first picture the plugin does not activate for action.yml because it's not somewhere at .github/workflows/

I currently have to rely on a link to trick the plugin image

image

YunaBraska commented 1 year ago

Haha! The link is next level. Cool 👍 Understand, so I need to support actions which are not under the .github folder. Roger that.

YunaBraska commented 1 year ago

The new Version 2.2.7 (will be public in few days) will have a better support for local actions. Syntax Highlighting and also Code Completion for action.yml files is on my list. Therefore, not every Intellisense will work inside the action.yml files.

YunaBraska commented 1 year ago

2.2.7 is published. You should have basic support for action.yml files. Further development to support action.yml is postponed in #20 on the Project Board I hope you understand, I need to focus and bring the plugin in a stable position first. There are some clean-ups left. I will link this issue in #20, so your input is not lost! Please continue reporting me bugs, features and more. It's always good to know where I can improve this plugin.

SimonSchwendele commented 1 year ago

Thanks a lot. It looks great and ( nearly ) everything I use can be used by now.

One thing which is still missing ( not urgent tho ): When I assing a id theres no autocompletion for the stepnames:

image

YunaBraska commented 1 year ago

Yes, that's cause of the dirty fix I made. Background: I currently apply logic from GitHub Workflows to GitHub Actions. But some rules are different in GitHub Actions - like your example, where you can go over the steps directly without having jobs. That's not possible in workflows. I need to implement rules specific for GitHub Actions ^^ Therefore the task #20

YunaBraska commented 1 year ago

@SimonSchwendele i have rewritten the whole plugin to stabilize things. Do you have anything left of your wishlist? 😇

SimonSchwendele commented 1 year ago

@SimonSchwendele i have rewritten the whole plugin to stabilize things. Do you have anything left of your wishlist? 😇

Finally some holiday for me :) I'm gonna test something next week tho. Saw you released a new version, really appreciating all your hard effort :)