YunaBraska / github-workflow-plugin

Your Ultimate Wingman for GitHub Workflows and Actions! 🚀
https://github.com/YunaBraska/github-workflow-plugin
Apache License 2.0
44 stars 10 forks source link

feat: Add code completion and annotator support for steps.*.{conclusion,outcome} #36

Closed siketyan closed 11 months ago

siketyan commented 11 months ago

Types of changes

Motivation

Why is this change required? What problem does it solve?

Code completion and annotation is incomplete for items under steps.* other than outputs.

Changes

Behaviour, Functionality, Screenshots, etc.

This pull request adds code completion and annotator support for steps.*.conclusion and steps.*.outcome. These properties are documented at https://docs.github.com/en/actions/learn-github-actions/contexts#steps-context.

image

Success Check

How can we see or measure the change?

Try opening this simple workflow:

name: checks

on:
  pull_request: ~

jobs:
  checks:
    runs-on: ubuntu-22.04
    steps:
      - uses: actions/checkout@v4
        id: checkout

      - run: echo "${{ steps.checkout.outcome }}"
YunaBraska commented 11 months ago

Wow amazing, 🤩 thank you. I will have a look on it tomorrow.

YunaBraska commented 11 months ago

The Version 3.1.0 is on the way 🎉.

Just one general thing, you only tested the happy path ^^ When you program, please also test the error cases. But no worries, I have added the step validation to the new case. Was a nice collaboration! Thank you! Greetings from Germany to Japan 🥇

siketyan commented 11 months ago

Sorry for missing test cases, thank you for quick review & merge!

YunaBraska commented 11 months ago

No worries, no sorry 😉 was just a friendly hint