YunaBraska
commented
11 months ago Thx for the feedback, I will fix it asap.
Closed YannCebron closed 11 months ago
YunaBraska
commented
11 months ago Thx for the feedback, I will fix it asap.
YunaBraska
commented
11 months ago Should be fixed now with version 2.0.4
SimonSchwendele
commented
11 months ago Is that surely resolved ?
And do composite actions work at all ?
I even added the github account to rider.
YunaBraska
commented
11 months ago The first example one should work. Unfortunately, JetBrains doesn't make it easy to refresh :( Its areal nightmare... I did some changes, but it's not reviewed yet, so fingers crossed, that this will fix it. As a manual workaround, you could try to add a space, save the file and remove a space at the end of the line.
*The second example** That's a new learning for me. Thx for pointing it out! I will have a look into this.
Sorry for so many bugs in the new release. Really embarrassing.
SimonSchwendele
commented
11 months ago Sorry for so many bugs in the new release. Really embarrassing.
Nah youre doing a great job here :). I guess you're testing all by yourself so of course some weird corner cases like "composite-actions" aren't covered.
The spacing workaround sadly does not work.
Actually no intellisense is functioning at all.
I dont see any logs in the notification window. Where can I find them ? Maybe it's windows... again
YunaBraska
commented
11 months ago There are no logs if nothing was detected.
1) Wait for Version 2.2.x (currently in review)
2) restart the whole IDE
3) Clear Cache - you will get the option at alt + return (Context Action) when the item was detected
4) Clear Cache manually - you can delete the folder ide_github_workflow_plugin in your temp folder and restart your IDE, this cleans the whole cache.
I wanted to do a lot of things like Syntax Highlighting, but for that I needed to exchange my yaml parsing from easy SnakeYaml to super hard PsiElements from JetBrains.
Not the hell started. These elements are making it really hard to find the whole context as I receive the events line and element wise. The Code Completion should work, but the syntax highlighting could take a while until it gets stable
SimonSchwendele
commented
11 months ago I tried steps 2-4 still missing the intellisense. I couldn't care less about the correct highlighting ( my IDE is mostly red during work ) but I really rely on the intellisense.
I'm building your main right now. Maybe that one works
YunaBraska
commented
11 months ago You could also switch back to version 1 until I find the issue
SimonSchwendele
commented
11 months ago You could also switch back to version 1 until I find the issue
I guess I'll do that for now. 2.2.1 doesnt work as well in my case.
I really hope you can do it because we write a lot custom actions and having intellisense there as well would be amazing 😄 .
Maybe it's just a rider thing.
Some regular stuff appears to be broken as well.
Update: Oh great that already works on 1.0.1. Should've added the github account sooner 😆
YunaBraska
commented
11 months ago Missing intellisense
I finally could reproduce it in Rider and Intellij. It seems a small issue detecting the cursor offset when there is no text in with:
For me, it works again as soon as there is at least one character.
Some regular stuff appears to be broken as well
I don't understand, as there is no IS_DRAFT in env: https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables therefore is highlighted.
The right way would be github.event.pull_request.draft from here: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
Do I miss something?
BTW: Thx for taking your time to report and try things out.
SimonSchwendele
commented
11 months ago The right way would be github.event.pull_request.draft from here: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
Sorry the draft variable does not check whether the PR is a draft but if the release should be a draft.
If you have a look at the env: section above we define the environment variable there.
It could've be wrrite like this as well:
gh release create *** --draft="${{ startsWith(github.ref_name, 'v.') == false && github.ref_name != 'master }}".
The screenshot I posted earlier contains another usage of upload-artifact where the with already contains some inputs.
Despite that the input retention-days is not recognized but the action.yml exposes it
YunaBraska
commented
11 months ago Small Update
Version 2.2.3 i still on review, we have to wait for it. When it's published, you will receive the following changes
Missing Intellisense: should work better now - At least it works on my machine with Intellij & RiderHighlighting Bug: I couldn't reproduce this behaviour. Can you give me a full Workflow file or link to your Workflow files?Composite Actions: I have added a first support for it. @SimonSchwendele Please test and feel free to report more use cases, as this is pretty new to me and the documentation tells me only one simple "hello world" example.YunaBraska
commented
11 months ago Version 2.2.3 is now available.
SimonSchwendele
commented
11 months ago Version 2.2.3 is now available.
Already testing it :)
In case the action resides in a remote repo the intellisense and stuff works.
Thanks a lot for implementing this feature :)
It's bad style so it doesnt matter that much to me personally, but when the composite file is a relative path within the repository the intellisense doesnt work again.
I guess thats due to it waiting for an action rather than a file
While I'm editing a composite action I don't get the intellisense as well.
However it appears some inputs are not recognized.
-> action.yml
-> action.yml
I need to write a lot of composite actions this Sprint. I really appreciate your implementation of this, thanks a lot for being so fast ❤️
YunaBraska
commented
11 months ago First the good things: Version 2.2.4 is now more responsive and refreshes the syntax highlighting faster. No more "Save File" to see changes.
I would like to fix this, but I have not much of an idea on composite actions. It would be helpful if you could send me a link to a repo or tell me more about the project path structure.
Same here, I probably need an example with composite action to understand.
Finally, I could reproduce the behaviour, after setting up a Windows machine. It looks like the JetBrains YAML Parser behaves differently - this bug is now my priority, but it could take a while...
SimonSchwendele
commented
11 months ago Thanks for keeping me up to date.
Finally, I could reproduce the behaviour, after setting up a Windows machine.
You're right about that.
Well I'll guess I'll do them on my private laptop and let Linux do its magic :laughing:
And guess what....
I'm deeply sorry my company forces me to use that uselesss OS -.-
YunaBraska
commented
11 months ago Happy Weekend @SimonSchwendele I could fix the missing inputs faster than estimated. This also relates to Syntax Highlighting. The Version 2.2.5 will fix probably all windows problems.
Please open a new issue for other problems or feature request, since the thread is pretty long here and was starting at a different error.
How can we reproduce the issue? Open GH workflow.yml file
Relevant log output
Environment com.github.yunabraska.githubworkflowplugin (2.0.2)
IntelliJ IDEA 2023.1.5 (Community Edition) Build #IC-231.9392.1, built on July 25, 2023 Runtime version: 17.0.7+10-b829.16 aarch64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. macOS 13.5 GC: G1 Young Generation, G1 Old Generation Memory: 4000M Cores: 20 Metal Rendering is ON Registry: debugger.new.tool.window.layout=true ide.experimental.ui=true writerside.preview.rebuild.delay=1000
Non-Bundled Plugins: com.intellij.grazie.pro (0.3.241) com.github.yunabraska.githubworkflowplugin (2.0.2) org.jetbrains.idea.grammar (2022.3.2) org.jetbrains.kotlin (231-1.9.0-release-358-IJ8770.65) com.jetbrains.sdk.tool (0.59-dev) com.jetbrains.writerside (2023.06.3869) com.intellij.mermaid (0.0.13-231)
Kotlin: 231-1.9.0-release-358-IJ8770.65