search

YungSang / fedora-atomic-packer

Fedora Atomic Packer for Vagrant Box
10 stars 7 forks source link

template_upgrade.json #6

Open kikitux opened 9 years ago

kikitux commented 9 years ago

add this option to template.json

  "keep_input_artifact": true,

and proposal of template_upgrade.json

YungSang commented 9 years ago

systemctl restart is not good in a provisioner. I'm testing my way without packer now.

kikitux commented 9 years ago

if you see the packer code, are 2 separate shell scripts.. packer is supposed to handle well reboots.

if higher timeout is needed, the 2nd block can include:

"pause_before": "30s"

On Sun, Oct 19, 2014 at 5:24 PM, YungSang notifications@github.com wrote:

systemctl restart is not good in a provisioner. I'm testing my way without packer now.

— Reply to this email directly or view it on GitHub https://github.com/YungSang/fedora-atomic-packer/pull/6#issuecomment-59638956 .

YungSang commented 9 years ago

Oh I see. I didn't know that. Thanks.

kikitux commented 9 years ago

Ok, moved to a separate directory.

did a run and took 6 minutes, but the files size were almost the same, which I think is good.

==> Builds finished. The artifacts of successful builds are: --> virtualbox: VM files in directory: output-virtualbox --> virtualbox: 'virtualbox' provider box: ../fedora-atomic-upgrade-virtualbox.box

real 6m32.485s user 0m30.922s sys 0m8.283s

z2-3:box_upgrade kikitux$ du -sh ../box/output-virtualbox/ output-virtualbox/ 395M ../box/output-virtualbox/ 397M output-virtualbox/

z2-3:box_upgrade kikitux$ du -sh ../*box 380M ../fedora-atomic-upgrade-virtualbox.box 378M ../fedora-atomic-virtualbox.box

YungSang commented 9 years ago

Thanks. I will try your template.

YungSang commented 9 years ago

And also it has to update oem-release as well.

kikitux commented 9 years ago

ok, did fix the 2

box/template.json comma, did swap the lines box_upgrade/tempalte_upgrade.json added oem

On Sun, Oct 19, 2014 at 11:10 PM, YungSang notifications@github.com wrote:

And also it has to update oem-release as well.

— Reply to this email directly or view it on GitHub https://github.com/YungSang/fedora-atomic-packer/pull/6#issuecomment-59645222 .

YungSang commented 9 years ago

Thank you so much! It looks good. I will try to upgrade it.

YungSang commented 9 years ago

I merged your PR into a branch https://github.com/YungSang/fedora-atomic-packer/tree/kikitux/upgrade temporarily. I found bugs and patched them. Please refer it.

It looks good, but sudo hostnamectl set-hostname <hostname> fails after upgrading. Strangely the box built from scratch (2014-10-19 06:12:58 bb56cbbc3c) has no problem. I will figure this out.

On the other hand, I also tested your PR using an box.ovf in yungsang/fedora-atomic v1.1.2 as a base OVF. The upgraded box is 100MB bigger than v1.1.2. I think that it's good for personal use but for public like yungsang/fedora-atomic at vagrant cloud.