search

YunoHost-Apps / Experimental_helpers

6 stars 12 forks source link

Allow reading service logs from systemd journal #18

Closed JimboJoe closed 6 years ago

JimboJoe commented 6 years ago

Use systemd journal for log inputs if specified log file is "systemd".

maniackcrudelis commented 6 years ago

Seems good to me, just one thing, have you checked the value get by $pid_tail, to be sure there's no problem with the if ?

JimboJoe commented 6 years ago

$pid_tail gets the right pid.

Not specifically related to this PR, the ynh_clean_check_starting isn't found in my scripts when used in the ynh_clean_setup used by ynh_abort_if_errors; I had to put it out of ynh_check_starting... Did it ever work for you, did I miss something...?

maniackcrudelis commented 6 years ago

Hum, the question would be, is a function is available outside of the scope of another function... I'm not sure though, and maybe the better thing would be to put this function outside to be sure.

maniackcrudelis commented 6 years ago

As soon as it's ok for you, merge, it's an experimental helper, no reason to bother us with long reviews.