search

YunoHost-Apps / Experimental_helpers

6 stars 12 forks source link

ynh_install_extra_repo and .asc key #33

Closed yalh76 closed 5 years ago

yalh76 commented 5 years ago

ynh_install_extra_repo --key argument only allow gpg file.

It would be great that key argument accept .asc files

"gpg --dearmor the-asc-file.asc" will convert from .asc to .gpg

maniackcrudelis commented 5 years ago

Hum ok, and in case the key is an asc, you can't load the key as it is ? Which app is concerned ?

yalh76 commented 5 years ago

If I provide the asc, the repository is not trusted.

it's for https://github.com/YunoHost-Apps/pleroma_ynh/tree/ynh_add_secure_repos__2 Here are the logs: https://paste.yunohost.org/upiracexof L387

maniackcrudelis commented 5 years ago

Ok I see the problem... The script store the key under the name $app.gpg, whether it's a gpg key or an asc...

Well, I'll work on it. Thanks for this bug report

maniackcrudelis commented 5 years ago

Done with https://github.com/YunoHost-Apps/Experimental_helpers/commit/218450f58f3220f8abba6d77d517bd362369bd08 Not tested, so tell me if it works as expected.

yalh76 commented 5 years ago

Yes, it works as expected. A big thank you.