Package upgrade - Githubissues

YunoHost-Apps / airsonic_ynh

Airsonic package for YunoHost

https://airsonic.github.io/

GNU General Public License v3.0

9 stars 7 forks source link

Package upgrade #1

Closed kay0u closed 5 years ago

kay0u commented 5 years ago

Solution

Fix all scripts
Add change url
Normalization from example_ynh

PR Status

[x] Code finished.
[x] Tested with Package_check.
[x] Fix or enhancement tested.
[x] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

[ ] Code review
[ ] Approval (LGTM)
Code review and approval have to be from a member of @YunoHost/apps group
CI succeeded :

kay0u commented 5 years ago

This time, everything works well and ready to merge

kay0u commented 5 years ago

Instead of postgres, why not using mysql / mariadb ?

With the current version packaged, postgres/mysql works well, but this the new one, it crashes at startup for no reason. I think there is a bug in airsonic. This feature could be added later, but it is not really necessary (or could be for performance reasons).

Thank you for your review!

kay0u commented 5 years ago

Package check is running, ready for review :-)

kay0u commented 5 years ago

Everything is working with package_check

Gofannon commented 5 years ago

Seems good, thanks. I guess that I can merge the branch directly. Tell me if I'm wrong :)

I will try to find time to try the "testing version"

kay0u commented 5 years ago

You're welcome!

Ping me if you find an issue or need some help! :-)

Don't forget to create a PR to set the status of airsonic as "working" apps.json once the testing branch is merged.

Gofannon commented 5 years ago

Alright, will do!