Testing - Githubissues

YunoHost-Apps / airsonic_ynh

Airsonic package for YunoHost

https://airsonic.github.io/

GNU General Public License v3.0

9 stars 7 forks source link

Testing #22

Closed Gofannon closed 4 years ago

Gofannon commented 4 years ago

Problem

Airsonic was often killed on my server because it uses a lot of RAM

Solution

Reduce RAM usage from 700mb to 256mb

PR Status

[x] Code finished.
[ ] Tested with Package_check.
[x] Fix or enhancement tested.
[x] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

[ ] Code review
[ ] Approval (LGTM)
Code review and approval have to be from a member of @YunoHost/apps group
CI succeeded :
Please replace '-NUM-' in this link by the PR number.
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

Gofannon commented 4 years ago

LGTM but I'm not from Apps Group so it doesn't counts...

It counts of course. You don't have to be a part of apps group to have your word :) It's nice to have someone else reading the code. This app is not "high quality" so member of "apps groups" review is not required.

Anyway, this version works on my server so let's merge!