YunoHost-Apps / akkoma_ynh

Social media based on ActivityPub, fork of Pleroma
https://akkoma.social/
GNU Affero General Public License v3.0
15 stars 6 forks source link

Static directory not removed at uninstall #16

Closed bugsysop closed 1 year ago

bugsysop commented 1 year ago

If you uninstall Akkoma, the static directory (/home/yunohost.app/akkoma/static/) is not removed or archived by the uninstall script of YNH...

This can be a problem in case of later installation of a new or clean instance of Akkoma for a new project for example.

The good idea can be to make a backup somewhere, as the static/ directory contain all the custom assets and files of the removed instance.

bugsysop commented 1 year ago

Read this on Forgejo YNH package README:

Due of the backup core only feature the data directory in /home/yunohost.app/forgejo is not removed. It must be manually deleted to purge user data from the app.

The solution is probably to inform the user with a CLI example to backup & remove the directory if necessary.

lapineige commented 1 year ago

That's an interesting way to do it ! We should also warn during backup I think (the backup core only option is too transparent).

bugsysop commented 1 year ago

We can add this information somwhere:

If someone want to delete the folder /home/yunohost.app/pleroma/ during removal of pleroma_ynh, it should add the --purge option. like all apps keeping datas in /home/yunohost.app/

https://github.com/YunoHost-Apps/pleroma_ynh/issues/233