search

YunoHost-Apps / ampache_ynh

Ampache package for YunoHost
http://ampache.org/
GNU General Public License v3.0
17 stars 16 forks source link

Upgrade fails #26

Closed maniackcrudelis closed 6 years ago

maniackcrudelis commented 6 years ago

Hello @aymhce, the upgrade process fails because of the variable $version which doesn't exist anymore after all helpers use local variables.

So, you have an issue here https://github.com/YunoHost-Apps/ampache_ynh/blob/master/scripts/upgrade#L87

But, my question is, which version number do you really need !? $version from the helper, as you used before, is the version number from the manifest, https://github.com/YunoHost-Apps/ampache_ynh/blob/master/manifest.json#L8, so 1.0. But the real version of Ampache that you use is 3.8.3 (according to the app.src). And which file is supposed to be remove by this command ?

aymhce commented 6 years ago

Hello, it's about a old portion of code. Forgeted it... Removed now.