YunoHost-Apps / ampache_ynh

Ampache package for YunoHost
http://ampache.org/
GNU General Public License v3.0
17 stars 16 forks source link

update #31

Closed aymhce closed 6 years ago

aymhce commented 6 years ago

Problem

Solution

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation


Minor decision

maniackcrudelis commented 6 years ago

@YunoHost-Apps/apps-group

@aymhce, for next PR, could you please make a branch on this repository then create a pull request from it ? It's easier for our CI, it can retrieves the branch and make a test by itself. For this PR, I had to clone the repository by myself, so now it isn't going to be automatically updated.

maniackcrudelis commented 6 years ago

Upgrade and code review OK

aymhce commented 6 years ago

@maniackcrudelis hello, thanks for review, can I merge it on branch testing ?

maniackcrudelis commented 6 years ago

As you can see, we have to wait for a last LGTM. And then wait 3 days before merging.

JimboJoe commented 6 years ago

Will be merged in 3 days :wink: