Normalization from example_ynh

YunoHost-Apps / ampache_ynh

Ampache package for YunoHost

http://ampache.org/

GNU General Public License v3.0

17 stars 16 forks source link

Normalization from example_ynh #49

Closed maniackcrudelis closed 4 years ago

maniackcrudelis commented 5 years ago

Problem

Global upgrade of the package.

PR Status

[x] Code finished.
[x] Tested with Package_check.
[ ] Fix or enhancement tested.
[ ] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[x] Code review : Kay0u
[x] Approval (LGTM) : Kay0u
[ ] Approval (LGTM) :
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis commented 4 years ago

Bump

Looks like the current version doesn't really works. There's no admin user and no directory loaded with some music. So after installation ampache becomes useless.

Without any adaptation, this branch solves my problem and gave me a functional Ampache after installation.

kay0u commented 4 years ago

^{_{pssst, LGTM}}

maniackcrudelis commented 4 years ago

Hum... May 10th... Let's merge...