YunoHost-Apps / ampache_ynh

Ampache package for YunoHost
http://ampache.org/
GNU General Public License v3.0
17 stars 16 forks source link

Update app to 4.0.0 #54

Closed Aeris1One closed 4 years ago

Aeris1One commented 4 years ago

Problem

Solution

PR Status

Validation


Minor decision

Aeris1One commented 4 years ago

🤔 I used the *-all.tar.gz archive, which include dependencies, so no need to use composer to install them.

Aeris1One commented 4 years ago

Finally upgraded to 4.1.1

Aeris1One commented 4 years ago

🤔 https://paste.yunohost.org/ucalohetuk

maniackcrudelis commented 4 years ago

WARNING - cp: cannot create regular file '/var/www/ampache/config/ampache.cfg.php': No such file or directory

Aeris1One commented 4 years ago

Idk why, that appears even with the 3.9.0 -_-

HugoPoi commented 4 years ago

@Aeris1One Ok I solve the cp issue we need SOURCE_IN_SUBDIR=false in conf/app.src !

HugoPoi commented 4 years ago

And we neep php 7.1 at minimum, so we need to use the new 3.8 feature for that see https://github.com/YunoHost/yunohost/pull/881

Example here https://github.com/YunoHost-Apps/nextcloud_ynh/pull/292/files

Aeris1One commented 4 years ago

@HugoPoi There's experimental helpers, we do not need to wait for 3.8, we can use experimental helpers. I'll edit the app.src, but I don't have enough time to debug the install script... Feel free to create a PR on the top of this one

maniackcrudelis commented 4 years ago

Please wait until 3.8, would be a lot safer than to use the experimental helpers. That php thing is quite tricky, it can explode at your face at any moment.

Even though, I do understand it can be frustrating

HugoPoi commented 4 years ago

I'm on it :sunglasses: