Fix - Githubissues

YunoHost-Apps / ampache_ynh

Ampache package for YunoHost

http://ampache.org/

GNU General Public License v3.0

17 stars 16 forks source link

Fix #60

Closed yalh76 closed 4 years ago

yalh76 commented 4 years ago

Problem

Fix #39
Fix #51
Fix #53

Solution

Based on #52
Integrate #54
Update to last master version
Upgrade to PHP7.3 as last version require PHP7.1 minimum

PR Status

[x] Code finished.
[x] Tested with Package_check.
[x] Fix or enhancement tested.
[x] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

For stretch:

HugoPoi commented 4 years ago

Minor stuff

Your Ampache config file is out of date! Can be fix with https://github.com/YunoHost-Apps/ampache_ynh/pull/56/files#diff-78c4f03616a9178de0c8b0de5b748640

yalh76 commented 4 years ago

Minor stuff

* `Your Ampache config file is out of date!`
  Can be fix with https://github.com/YunoHost-Apps/ampache_ynh/pull/56/files#diff-78c4f03616a9178de0c8b0de5b748640

Thanks, I haven't checked that. I was more working on the general package than on the upstream app ^^

yalh76 commented 4 years ago

So ready to merge after the update of the configuration ?

HugoPoi commented 4 years ago

I think so, I have tested the upgrade and the installation from scratch all running good.

I have notice some "composer" related message in the logs, we no longer use composer ?

yalh76 commented 4 years ago

Yes we still use composer, that's why you might have composer related messages ^^

HugoPoi commented 4 years ago

Ok too late, what is version packaged in ?

We can address my comments in future PR.

yalh76 commented 4 years ago

Ok too late, what is version packaged in ?

I'm not sure to understand your question... it's 4.1.1 + some commits...

We can address my comments in future PR.

Yes feel free. My goal was just to make ampache work