YunoHost-Apps / audiobookshelf_ynh

Audiobookshelf package for YunoHost
https://audiobookshelf.org/
GNU General Public License v3.0
4 stars 4 forks source link

Upgrade to 2.0.20 #13

Closed Thovi98 closed 2 years ago

Thovi98 commented 2 years ago

Thanks @yalh76 for making this package perfect !

Problem

Solution

/!\ upgrade from version before example did remove all my settings, users and libraries. I’ve just to reconfigure them. Not a big issue.

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

yalh76 commented 2 years ago

/!\ upgrade from version before example did remove all my settings, users and libraries. I’ve just to reconfigure them. Not a big issue.

Where are located those settings, users and libraries ? in $datadir

Thovi98 commented 2 years ago

There where in /var/www/audiobookshelf/, now it’s /home/yunohost.app/audiobookshelf/

yalh76 commented 2 years ago

ok, then the move of the datas from /var/www/audiobookshelf/, to /home/yunohost.app/audiobookshelf/ wasn't managed during upgrade, do we have to manage it in #12 ?

Thovi98 commented 2 years ago

Since it’s a relatively new package which wasn’t at high level, for me it’s okay to "break" older installations this time. What about you ?

yalh76 commented 2 years ago

Since it’s a relatively new package which wasn’t at high level, for me it’s okay to "break" older installations this time. What about you ?

It's better to not break things ^^ It's quite easy to manage the move of the datas ... For example, you have https://github.com/YunoHost-Apps/vaultwarden_ynh/blob/847396d849b573843eda1098e5d8d002defa3fd3/scripts/upgrade#L129-L139

Thovi98 commented 2 years ago

But you merged #12 😁 I’ve no time for now to look at it unfortunately..

yalh76 commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Alrighty! Test Badge

yalh76 commented 2 years ago

@Thovi98 , do we merge ?

Thovi98 commented 2 years ago

For me it’s okay 👍 I’ve already upgrade and it works great !