search

YunoHost-Apps / bookstack_ynh

BookStack package for YunoHost
https://www.bookstackapp.com/
GNU General Public License v3.0
12 stars 3 forks source link

App key should be saved #130

Open tituspijean opened 1 year ago

tituspijean commented 1 year ago

Describe the bug

https://github.com/YunoHost-Apps/bookstack_ynh/blob/d615c709f3df01ae9e1a630e9e961cdfbef9d1d3/conf/.env.example.complete#L18

This line is being overwritten during each upgrade. Let's store the key.

ericgaspar commented 1 year ago

The key gets regenerated with https://github.com/YunoHost-Apps/bookstack_ynh/blob/d615c709f3df01ae9e1a630e9e961cdfbef9d1d3/scripts/upgrade#L98 Not really sure if it's a issue not to keep the same key.

tituspijean commented 1 year ago

It's a feedback from a user who came to the Yunocamp, let's wait for his new test tonight. I tested myself, and I indeed saw no issue while upgrading and changing the key.