search

YunoHost-Apps / bookstack_ynh

BookStack package for YunoHost
https://www.bookstackapp.com/
GNU General Public License v3.0
12 stars 4 forks source link

Proof of concept MinIO #71

Closed Limezy closed 2 years ago

Limezy commented 2 years ago

Hi @ericgaspar, as promised this is a proof of concept for using MinIO with Bookstack. Hope it will help, Best.

Limezy commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:carousel_horse: Test Badge

Limezy commented 2 years ago

That being made and said, I'm not 100% sure about the real benefit of using MinIO for Bookstack, knowing that the app is already supporting a local storage mode, which is probably the most efficient for small VPS or old computers such as the one used by Yunohost users. I have been working on MinIO for Outline just because Outline doesn't support (and will probably never support) local storage.

Limezy commented 2 years ago

I read here : https://www.bookstackapp.com/docs/admin/upload-config/ "For performance reasons uploaded images are made public upon upload to your s3 bucket and fetched directly by the end user when viewing an image on BookStack" Well, in our case... there is no performance difference since both the MinIO instance and the Bookstack instance are served from the same computer 🤣

ericgaspar commented 2 years ago

You are right about MinIO benefice in bookstack. It adds a lot of complexity without real performance. I'll test this to see how MinIO works (witch I am still discovering). Thanks for showing me how to integrate it with BookStack.

Limezy commented 2 years ago

With pleasure. Please don't hesitate if you have any question. Note : I don't believe MinIO to be very useful for the Yunohost ecosystem (unless there is another app only supporting S3 storage) but I strongly believe that Dex could help fully integrating a whole lot of apps that don't have a direct LDAP connector. OIDC auth flow is used quite a lot these days. So don't hesitate too if you have any question about how to use Dex to have an OIDC compatible app connecting to the Yunohost's LDAP userbase