Various fixes needed to make app run

ndarilek commented 2 years ago

Problem

Sudo threw warnings because the permissions on the config file weren't correct.
The unit file ran the command with sudo, but a) the script runs sudo when necessary anyway and b) the script isn't in the list of allowed sudo commands. As such, the unit just didn't work.

Solution

Set permissions correctly.
Don't use sudo in the unit.

Closes #118

PR Status

[X] Code finished and ready to be reviewed/tested
[X ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ndarilek commented 2 years ago

How can I join @Yunohost-Apps? I'd like to help, and have already opened various PRs to fix issues I've encountered.

tituspijean commented 2 years ago

Thank you for the fixes! So sorry we did not see your ping earlier. 😕 I'm on mobile right now so I can't do much. Feel free to drop a message in the YunoHost Apps channel. ;)

tituspijean commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Fingers crossed!

YunoHost-Apps / borg_ynh