search

YunoHost-Apps / borg_ynh

An experimental Borg implementation for YunoHost
https://www.borgbackup.org/
GNU Affero General Public License v3.0
19 stars 25 forks source link

Support multiple repositories (values separated by `;`) #149

Open fflorent opened 5 months ago

fflorent commented 5 months ago

Problem

Fixes #146

When backuping with multiple repositories, you'd have to install twice the borg app. If I am not wrong, this causes to copy (link) apps data as many times as you have repositories, which can take time depending on the apps being backed up.

Solution

Instead, this patch proposes to install a single client for multiple repositories.

Note: Probably this PR would need #148, if we'd prefer separating values by newlines instead of semi-colons.

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

zamentur commented 5 months ago

This part should be adapted to : https://github.com/YunoHost-Apps/borg_ynh/blob/master/scripts/config#L50

zamentur commented 5 months ago

And also the manifest.toml (testing branch) and the config_panel.toml

fflorent commented 5 months ago

@zamentur Right, thanks for the explanation, so knowing that, do you think it could be still a good idea? I don't mind closing this PR if there is not much benefits.

zamentur commented 5 months ago

I guess it's still a good idea for apps which have a big db (for example synapse).