YunoHost-Apps / borg_ynh

An experimental Borg implementation for YunoHost
https://www.borgbackup.org/
GNU Affero General Public License v3.0
19 stars 25 forks source link

Fix mail encoding and typos #161

Closed CodeShakingSheep closed 3 months ago

CodeShakingSheep commented 3 months ago

Problem

Mail encoding In the mails sent from borg at the end of some lines there were these signs …. See screenshot. image

Typos Furthermore, when the backups were successful, the mail subject was like this [borg] Backup succeed from [...] which is incorrect past tense of succeed.

Solution

Mail encoding The affected lines originate from the borg log files in which instead of … there are 3 points ... at the end of those lines. So, I believe that this is an encoding issue. See https://www.i18nqa.com/debug/utf8-debug.html . I applied the solution suggested here using -a parameter in the mail command.

Typos I fixed the typos so that the mail subject is like this now [borg] Backup succeeded from [...] which is correct past tense of succeed. Additionally, I fixed a typo in backup-with-borg's comments.

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

CodeShakingSheep commented 3 months ago

!testme

yunohost-bot commented 3 months ago

:books: Test Badge

yunohost-bot commented 3 months ago

:rocket: Test Badge