YunoHost-Apps / borg_ynh

An experimental Borg implementation for YunoHost
https://www.borgbackup.org/
GNU Affero General Public License v3.0
19 stars 23 forks source link

Yunohost diagnosis reports borg service status to be dead #53

Closed eauchat closed 3 years ago

eauchat commented 3 years ago

Maybe I configured something wrong, but in my yunohost server, ynh diagnosis is raising errors saying that borg service is dead.

From what I understand, it makes sense that the service is dead, since it's starting only when it's making a backup. It would be really nice indeed to know when backups are failing, but maybe the yunohost diagnosis should behave differently for borg_ynh service than other services. Maybe it should consider "dead" status to be ok, and raise an error if the status of the service is "failed".

But maybe I misunderstood something. Or I can imagine that it's not trivial to implement.

zamentur commented 3 years ago

I have just add in testing --test_status="systemctl show $app.service -p ActiveState --value | grep -v failed"

So it should fix this situation, dead state and inactive state seems ok indeed