Testing - Githubissues

YunoHost-Apps / code-server_ynh

Code-server packaged for YunoHost

https://github.com/cdr/code-server

MIT License

6 stars 2 forks source link

Testing #66

Closed ericgaspar closed 10 months ago

ericgaspar commented 10 months ago

Problem

Description of why you made this PR

Solution

And how do you fix that problem

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ericgaspar commented 10 months ago

!testme

yunohost-bot commented 10 months ago

Meow :cat2:

Tagadda commented 10 months ago

!testme

yunohost-bot commented 10 months ago

:rocket:

ericgaspar commented 10 months ago

You basically reverted all changes of this PR 😅

Tagadda commented 10 months ago

Yes, here code-server is run as the user selected during the install. We don't want any other user to access the app.

ericgaspar commented 10 months ago

Yes, but surly there is a way to achieve that without using ynh_permission_update

Tagadda commented 10 months ago

With manifest v2, not that I know of... The question init_main_permissions only allows for groups to be selected.

ericgaspar commented 10 months ago

what about main.allowed = "admins"? Will this not achive the same as ynh_permission_update --permission="main" --add="$admin"?

Tagadda commented 10 months ago

It's not the same at all. main.allowed = "admins" will grant access to the admins group ynh_permission_update --permission="main" --add="$admin" will grant access to the user selected during install

Tagadda commented 10 months ago

!testme

yunohost-bot commented 10 months ago

Meow :cat2: