YunoHost-Apps / collabora_ynh

Collabora package for YunoHost
https://www.collaboraoffice.com/
GNU General Public License v3.0
16 stars 13 forks source link

Testing #40

Closed alexAubin closed 3 years ago

alexAubin commented 3 years ago

Problem

Solution

I don't know how to fully test the app though (gotta integrate it in nextcloud i suppose)

alexAubin commented 3 years ago

Trying to investigate with a user why the nextcloud integration wasnt working, encountered this kind of issue https://github.com/CollaboraOnline/Docker-CODE/issues/49 ... turns out we don't have the <net> block config in our current loolwsd.xml

In fact, looking at the diff with the default loolwsd.xml we have quite a few missing things (probably because of lack of maintenance on this app)

c.f. attached file savagely extracted from https://www.collaboraoffice.com/repos/CollaboraOnline/CODE-debian10/loolwsd_6.4.3-3_amd64.deb :

loolwsd.xml.orig.txt

Diff with :

git diff --no-index loolwsd.xml.orig.txt loolwsd.xml
Thatoo commented 3 years ago

Does it work simply replacing the current yunohost loolwsd.xml file by the loolwsd.xml.orig.txt you extracted?

alexAubin commented 3 years ago

I don't know

ericgaspar commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:rocket: Test Badge

ericgaspar commented 3 years ago

Backup/restore tests seem to be successful in the old CI ...

alexAubin commented 3 years ago

Zblerg, not sure what happens from the log, there's nothing apart from a "Killed" in the systemd log, which could suggest that it's a resource issue, or that the process got killed by systemd after a "stop" being triggered ...

alexAubin commented 3 years ago

I savagely restarted the test just in case it's a tmp issue

ericgaspar commented 3 years ago

@alexAubin ping for merge?

alexAubin commented 3 years ago

We still need to address the previous comment https://github.com/YunoHost-Apps/collabora_ynh/pull/40#issuecomment-760370748 ... Like, I was discussing with a user the day I wrote it that could not integrate Collabora in Nextcloud because of the lack of some section of this config file .. But my todolist is too huge to have time to look deeper into this :/

ericgaspar commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:v: Test Badge