search

YunoHost-Apps / dato_ynh

Dato package for YunoHost
GNU Affero General Public License v3.0
6 stars 1 forks source link

Upgrade to v1.7.2 #31

Closed yunohost-bot closed 5 months ago

yunohost-bot commented 5 months ago

Upgrade to v1.7.2 https://framagit.org/squeak/dato/-/releases/v1.7.2

yunohost-bot commented 5 months ago

Fingers crossed! Test Badge

eauchat commented 5 months ago

Can't test this at the moment because I don't have a working testing environment. Upstream doesn't have any breaking change so there shouldn't be any problem on that side.

eauchat commented 5 months ago

I added a little commit to remove package-lock.json and node_modules before re installing them (in upgrade script). I don't know if I coded it the right "yunohost" way, so if someone can check I did it right that'd be great.

Maybe removing those two elements before upgrading node modules is not the best practice. But many dato dependencies are not on npm and are installed directly from git repos, so as of the last tests I had done, it didn't handle well version and upgrades. So the recommended way to upgrade dato is to remove those elements before upgrade.