search

YunoHost-Apps / dendrite_ynh

Matrix homeserver of second-generation, packaged for YunoHost
GNU General Public License v3.0
16 stars 8 forks source link

Install golang from debian package #106

Open Gredin67 opened 1 year ago

Gredin67 commented 1 year ago

Can't we do it as I used to do for mautrix_whatsapp (before pre-built use) ? https://github.com/YunoHost-Apps/mautrix_whatsapp_ynh/blob/443ac4fb96297455281d9495844dde3b9a197214/scripts/install#L126

tituspijean commented 1 year ago

What do you think @yalh76?

It looks like golang-go is even available in the oldstable repos, backports are not needed.

yalh76 commented 1 year ago
  • Why not install golang-go from its debian package rather that from github ? I think usually it is backward compatible. And if not, the upstream should upgrade the required go version.

I don't know if it backward compatible, but Dentrite require Golang 1.18 and bullseye provide Golang 1.15

* Why remove it after building, which requires to reinstall go for an upgrade

Because at next upgrade, the version of go will be updated, so the version of go used during install won't be used during next upgrade... So no good reason to keep it.

Can't we do it as I used to do for mautrix_whatsapp (before pre-built use) ? https://github.com/YunoHost-Apps/mautrix_whatsapp_ynh/blob/443ac4fb96297455281d9495844dde3b9a197214/scripts/install#L126

It's up to the maintainer to decide but using the helper ynh_install_go, the maintainer can choose any version available with goenv from 1.2.2 to 1.20.6. with backport you can only go to 1.19

orhtej2 commented 1 year ago

Another issue is that at this point dendrite fails to build against Go 1.21 and AFAIK we cannot specify upper bound for dependencies installed with apt, right?