Upgrade

[yalh76]

Problem

• Fix https://github.com/YunoHost-Apps/discourse_ynh/issues/111

Solution

• *Switch from __PATH_URL__ to __PATH__

PR Status

• [ ] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[artybdrlt]

Hello,

Thank you for this quick fix. We tried it but it doesn't fix the problem. In our case installing discourse on forum.domain.tld without a path, we still have a / in line relative_url_root (in config/discourse.conf). However, this causes problems for discourse.

The problem seems to have arisen because of the change of the installation method since this commit.

The way you used to install and configure an hostname for Discourse worked as intended (with the file scripts/install)

By doing various tests today, and by reading the scripts (and YunoHost helper scripts), we think we have found the origin of the problem.

We have the following variables:

path_url="/"
domain="forum.domain.tld"

The helper function ynh_add_config will replace in the template the variables using the function ynh_replace_vars.

In this function there are two paterns:

• __PATH__/: replaced by the path_url without slash to which we add the slash, the idea is to always have a / at the end of the path
• __PATH__ : replaced by the path_url but without removing the potential slash, in this case the PATH can have, or not, a / at the end.

What do you think about that?