search

YunoHost-Apps / discourse_ynh

Discourse package for YunoHost
https://www.discourse.org/
GNU General Public License v2.0
24 stars 11 forks source link

Remove swap requirement #149

Closed BDouze closed 4 months ago

BDouze commented 1 year ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

JimboJoe commented 1 year ago

Thanks for your proposal. Having a swap is an upstream requirement, so I think it's better to stick to that, so that Discourse support can be provided if needed (and to avoid what was feared initially: random process termination during upgrade).

What could possibly be done to answer your need would be to automatically create that file swap during the installation. I think there are already a couple of packages out there that do just that, aren't there? @YunoHost-Apps/apps-group

zamentur commented 1 year ago

On some VPS (using ZFS), it's not possible to create a swap file. I agree if there is a lot of ram we probably should ignore this requirement (upstream says swap file is needed with 1G ram).

tio-trom commented 10 months ago

Please either remove this or bring it down to 10. 50 for swapiness is a lot in my view. Even Discord recommends 10 https://meta.discourse.org/t/create-a-swapfile-for-your-linux-server/13880

I moved to a new server where I cannot modify the swapiness and it is 10. So I cannot restore my Discord...

Makes total sense if you have enough RAM to skip this high requirement. I have 40GB of RAM and I cannot install discord because my swapiness is 10....

tio-trom commented 10 months ago

How about doing it like this https://github.com/YunoHost-Apps/discourse_ynh/pull/161 ?

Salamandar commented 4 months ago

Closed in favor of #161