search

YunoHost-Apps / dokuwiki_ynh

Dokuwiki package for YunoHost
https://www.dokuwiki.org/dokuwiki
GNU General Public License v3.0
11 stars 16 forks source link

Upgrade de l'application #23

Closed magikcypress closed 7 years ago

magikcypress commented 7 years ago

Mise à jour de l'application pour qu'elle passe package check.

M5oul commented 7 years ago

Wow, all this modifications on one commit. That won't be easy to review. I let interested people review it.

magikcypress commented 7 years ago

Sorry, I'm working on a repository in my home and I push my work in a single commit. It's not a good idea. I sent my requests here https://github.com/magikcypress/dokuwiki_ynh_review/commits/master

maniackcrudelis commented 7 years ago

All seems good. But you used my old package style. If you don't mind, I'll try to upgrade it to more recent rules.

magikcypress commented 7 years ago

could you please comment your additions to nginx.conf (X headers for instance) and you php-fpm.ini?

I copy/paste this configuration on my all apps, but indeed the header is not necessary. php-fpm.ini same. I will remove this glut.

magikcypress commented 7 years ago

Normally this is good for me. I tested functionality and all good too.

Work:

Sources here: https://github.com/magikcypress/dokuwiki_ynh Tests here: https://jenkins-apps.nohost.me/jenkins/job/dokuwiki_cyp/

Have fun

magikcypress commented 7 years ago

Ok, thanks for this good review. After upgrade a version is change for the stable version. I don't see the link for stable version into dokuwiki website ;)

JimboJoe commented 7 years ago

@maniackcrudelis Shall we make this PR hold the decision and needed Apps group votes or shall the PR on official.json hold that decision... ?

maniackcrudelis commented 7 years ago

Oh, it's not really defined. So, in fact, even if this pull request is merged, as this app is official, it's doesn't deployed.

So, what can I say you? Maybe slide this decision to official app list can help it to have more attention.

JimboJoe commented 7 years ago

@magikcypress I've successfully upgraded my Dokuwiki instance in production 👍

The plugins update process is very verbose, and can feel a little bit frightening (download failure for unofficial plugins), especially when you have many plugins (which is my case). Could you maybe make it less verbose: just state when a plugin is upgraded, and be silent for any other case... ?

JimboJoe commented 7 years ago

Tested successfully on my side 👍 Maybe you could state during upgrade and/or in the README that the upgrade process upgrades official DokuWiki plugins as well...? We can't make sure plugins won't break anything, so we'd better be explicit :-)