YunoHost-Apps / dokuwiki_ynh

Dokuwiki package for YunoHost
https://www.dokuwiki.org/dokuwiki
GNU General Public License v3.0
11 stars 16 forks source link

Update script doesn't update nginx configuration file #31

Closed JimboJoe closed 5 years ago

JimboJoe commented 7 years ago

When upgrading this package, the script doesn't handle upgrading the nginx configuration file, although some enhancements can be applied by upgrading (like this one)

Gofannon commented 6 years ago

Should be fixed by the new version I guess ? https://github.com/YunoHost-Apps/dokuwiki_ynh/blob/testing/scripts/upgrade#L178-L183

Gofannon commented 5 years ago

In my opinion, the issue can be closed.

Package uses the helper ynh_add_nginx_config which overwrite nginx configuration See https://github.com/YunoHost-Apps/dokuwiki_ynh/blob/master/scripts/upgrade#L173