Fix conf folder handling + fix admin user + misc enhancements

Gofannon commented 6 years ago

Problem

Modifications are done in the "conf" folder instead of copying the template to "$final_path" and doing the modification there

Solution

Reverse the order of modification
1. copy conf template to $final_path
2. modify file in $final_path

Edit

While review, I fixed other issues so I changed the tittle of the PR. See commit messages for detail.
PR has been tested on a jessie VM like this
- upgrade from previous version
- backup / delete app / restore app
- install a new wiki with yunohost app install https://github.com/Gofannon/dokuwiki_ynh/tree/fix_conf_folder_handling --debug

PR Status

[X] Code finished.
[X] Tested with Package_check.
[X] Fix or enhancement tested.
[X] Upgrade from last version tested.
[X] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[x] Code review : Maniack C, JimboJoe
[x] Approval (LGTM) : Maniack C
[x] Approval (LGTM) : JimboJoe
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

Gofannon commented 6 years ago

Thanks for the fixes and review.

Error in upgrade script

According to package_linter, there is an error in the upgrade script and I cannot fix it :/ I don't know where it comes from.

from the CI

>> Package linter... [Test 1/11]
Traceback (most recent call last):
  File "/home/CI_package_check/dev_CI/../package_check/package_linter/package_linter.py", line 382, in <module>
    check_script(app_path, script, script_nbr)
  File "/home/CI_package_check/dev_CI/../package_check/package_linter/package_linter.py", line 252, in check_script
    check_non_helpers_usage(read_file(script_path))
  File "/home/CI_package_check/dev_CI/../package_check/package_linter/package_linter.py", line 313, in check_non_helpers_usage
    if "exit" in script:
  File "/usr/lib/python3.5/shlex.py", line 263, in __next__
    token = self.get_token()
  File "/usr/lib/python3.5/shlex.py", line 90, in get_token
    raw = self.read_token()
  File "/usr/lib/python3.5/shlex.py", line 166, in read_token
    raise ValueError("No closing quotation")
ValueError: No closing quotation

from my computer

>>>> UPGRADE SCRIPT <<<<
Traceback (most recent call last):
  File "./package_linter.py", line 382, in <module>
    check_script(app_path, script, script_nbr)
  File "./package_linter.py", line 252, in check_script
    check_non_helpers_usage(read_file(script_path))
  File "./package_linter.py", line 313, in check_non_helpers_usage
    if "exit" in script:
  File "/usr/lib/python3.6/shlex.py", line 295, in __next__
    token = self.get_token()
  File "/usr/lib/python3.6/shlex.py", line 105, in get_token
    raw = self.read_token()
  File "/usr/lib/python3.6/shlex.py", line 187, in read_token
    raise ValueError("No closing quotation")
ValueError: No closing quotation

JimboJoe commented 6 years ago

Woops, thanks for the fix :+1:

maniackcrudelis commented 6 years ago

Looks good to me