[doc] add a note on enabling XML-RPC

YunoHost-Apps / dokuwiki_ynh

Dokuwiki package for YunoHost

https://www.dokuwiki.org/dokuwiki

GNU General Public License v3.0

11 stars 16 forks source link

[doc] add a note on enabling XML-RPC #46

Closed pbernery closed 2 years ago

pbernery commented 5 years ago

Problem

I missed some help when I enabled the XML-RPC feature on Dokuwiki. It didn't work after being enabled because YunoHost rejected the call to the API.

Solution

The xmlrpc endpoint must be removed from the SSO check. This PR proposes a documentation on how to skip the check on the XML-RPC path.

Validation

Minor decision

Upgrade previous version :
[ ] Code review :
[ ] Approval (LGTM) :
[ ] Approval (LGTM) :
CI succeeded : or
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

Gofannon commented 5 years ago

Hello,

Thanks for your proposal!

After looking at the example plugin https://www.dokuwiki.org/plugin:sync, adding this note in the README is a good idea in my opinion.

JimboJoe commented 5 years ago

Hmm, should that URI be always unprotected (thus avoiding a manual operation)...? :thinking:

Gofannon commented 5 years ago

Hmm, should that URI be always unprotected (thus avoiding a manual operation)...? 🤔

I don't think so as it will allow the whole internet to discuss directly with the DokuWiki. It can leads to security issues and Fail2ban does not work correctly https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/44

Also, I don't think that this functionality will be used by a lot of people. I believe that it should be handled by the action_script mechanism

Gofannon commented 5 years ago

bump