Url rewriting - Githubissues

YunoHost-Apps / dokuwiki_ynh

Dokuwiki package for YunoHost

https://www.dokuwiki.org/dokuwiki

GNU General Public License v3.0

11 stars 16 forks source link

Url rewriting #54

Closed Gofannon closed 4 years ago

Gofannon commented 4 years ago

Problem

Fix https://github.com/YunoHost-Apps/dokuwiki_ynh/issues/51

Solution

Add URL rewrite
Install tested manually on "root domain" ( wiki.myDomain.org ) and "sub path" (myDomain.org/dokuwiki)
Tested using "change URL" from YunoHost web admin too

PR Status

[X] Code finished.
[ ] Tested with Package_check.
[X] Fix or enhancement tested.
[ ] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[x] Code review : JimboJoe
[x] Approval (LGTM) : JimboJoe
[x] Approval (LGTM) : Maniack C
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

JimboJoe commented 4 years ago

Can be merged in 3 days.