[Fix] caching pictures that didn't work - Githubissues

YunoHost-Apps / dokuwiki_ynh

Dokuwiki package for YunoHost

https://www.dokuwiki.org/dokuwiki

GNU General Public License v3.0

11 stars 16 forks source link

[Fix] caching pictures that didn't work #62

Closed Gofannon closed 4 years ago

Gofannon commented 4 years ago

Set HTTP Headers 'Expires' on the correct PATH...

Problem

Caching didn't work on pictures (HTTP header not set)

Solution

Fix path in nginx

After fix, you will have the missing header

dokuwiki_issue57

PR Status

[X] Code finished.
[ ] Tested with Package_check.
[X] Fix or enhancement tested.
[x] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[ ] Code review :
[ ] Approval (LGTM) :
[ ] Approval (LGTM) :
CI succeeded :

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis commented 4 years ago

@Gofannon, this PR can't be tested because of the name of your branch. Please do not use a slash in your branch names.

Gofannon commented 4 years ago

Replaced by https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/65 which has a different branch name. Content is the same.