YunoHost-Apps / dokuwiki_ynh

Dokuwiki package for YunoHost
https://www.dokuwiki.org/dokuwiki
GNU General Public License v3.0
11 stars 16 forks source link

[fix] dedicated named location per $app #63

Closed Gofannon closed 4 years ago

Gofannon commented 4 years ago

fix multiple install on subdomains

Before this fix app1 => @dokuwiki - works app2 => @dokuwiki - fails

After \o/ app1 => @app1 - works app2 => @app2 - works


Problem

Solution

Test

On the same domain (root or subdomain), install

  1. https://myDomain/dokuwiki1
  2. https://myDomain/dokuwiki2

Visit https://myDomain/dokuwiki2 and go to another page than $home (like $admin or create a $new page)

PR Status

Validation


Minor decision

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

Gofannon commented 4 years ago

Fix validated on the forum by madmaxlamenace

Gofannon commented 4 years ago

Conflict solved in CLI but I cannot push to master as an approval is required

To github.com:YunoHost-Apps/dokuwiki_ynh.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:YunoHost-Apps/dokuwiki_ynh.git'
➜  dokuwiki_ynh git:(master) 
maniackcrudelis commented 4 years ago

Indeed, branches testing and master are protected, you can't commit directly to those branches.

As the app is not official anymore, you can merge in 3 days.

Gofannon commented 4 years ago

Lets merge