search

YunoHost-Apps / dokuwiki_ynh

Dokuwiki package for YunoHost
https://www.dokuwiki.org/dokuwiki
GNU General Public License v3.0
11 stars 15 forks source link

Igor #92

Closed Gofannon closed 1 year ago

Gofannon commented 1 year ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Gofannon commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Fingers crossed! Test Badge

Gofannon commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Fingers crossed! Test Badge

Gofannon commented 1 year ago

@YunoHost-Apps/apps-group, some questions:

  1. CI is "lying" about the failed "install in private" mode. It works when I install the branch manually. Any ideas of what is happening? I will push it anyway because it "works on my server"
  2. What does this code do? https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/92/commits/26a16c44d0c58d1413c6c7beb5ca45ecfcf7ddfd I have no idea reading the "example_ynh" package but I used it anyway
  3. I plan to "backport" to example_ynh my troubles for handling "PHP in a package". Is a PR on the example_ynh package the right place to discuss this? (using "extra_php-fpm.conf" for example)
tituspijean commented 1 year ago
  1. CI is "lying" about the failed "install in private" mode. It works when I install the branch manually. Any ideas of what is happening? I will push it anyway because it "works on my server"

It's a long standing bug in the dev CI. You can safely ignore it.

What does this code do? https://github.com/YunoHost-Apps/dokuwiki_ynh/commit/26a16c44d0c58d1413c6c7beb5ca45ecfcf7ddfd I have no idea reading the "example_ynh" package but I used it anyway

As stated in the comment, you can remove it if there's nothing weird you did with the app that you need to cleanup with a custom function. I personally never saw it used in production. I sometimes use it in development with a read -p "debug me" to hold the removal script and give me time to investigate whenever a script fails.

I plan to "backport" to example_ynh my troubles for handling "PHP in a package". Is a PR on the example_ynh package the right place to discuss this? (using "extra_php-fpm.conf" for example)

Sure, we will see with the other team members if we should showcase this code in the example app.

Gofannon commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:stuck_out_tongue_winking_eye: Test Badge

Gofannon commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:carousel_horse: Test Badge

Gofannon commented 1 year ago

Tested on my server, it's fine to me. Code can be reviewed. For changes, see the Changelog. If I miss to write something, you can add it to the changelog directly

Gofannon commented 1 year ago

I have no solution for implementing fail2ban for now. I posted on the dokuwiki forum about this and need to spend time on it : https://forum.dokuwiki.org/d/20414-protection-against-bruteforce-login On the yunohost side, do "ldap logins" made by dokuwiki are monitored by fail2ban? This way, no need to put it in dokuwiki as it could be handled by yunohost directly