Apply example_ynh - Githubissues

YunoHost-Apps / dokuwiki_ynh

Dokuwiki package for YunoHost

https://www.dokuwiki.org/dokuwiki

GNU General Public License v3.0

11 stars 15 forks source link

Apply example_ynh #95

Closed yalh76 closed 1 year ago

yalh76 commented 1 year ago

Solution

Apply example_ynh

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

yalh76 commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:carousel_horse:

Gofannon commented 1 year ago

CI seems happy so am I. Agreed for the changes

Is there any "easy / quick" way to apply the "latest example_ynh version" to a package? It took me way too much time to do it properly by making the diff manually and to split changes in small commits

yalh76 commented 1 year ago

CI seems happy so am I. Agreed for the changes

Is there any "easy / quick" way to apply the "latest example_ynh version" to a package? It took me way too much time to do it properly by making the diff manually and to split changes in small commits

No there isn't for now, would be much easy with Manifest/packaging v2

On my side, I use winmerge to compare example_ynh to the app_ynh

yalh76 commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Alrighty!

Gofannon commented 1 year ago

No there isn't for now, would be much easy with Manifest/packaging v2

Seems really different. If some documentation is done, i might have a look.

On my side, I use winmerge to compare example_ynh to the app_ynh

What a huge task... So essential to do to habe "clean apps) but so "invisible work" and "boring" (to me at least)

yalh76 commented 1 year ago

No there isn't for now, would be much easy with Manifest/packaging v2

Seems really different. If some documentation is done, i might have a look.

On my side, I use winmerge to compare example_ynh to the app_ynh

What a huge task... So essential to do to habe "clean apps) but so "invisible work" and "boring" (to me at least)

Not that huge, it requires 15 to 30 minutes to apply :)

Gofannon commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:carousel_horse: