YunoHost-Apps / etherpad_mypads_ynh

Etherpad MyPads package for YunoHost
http://etherpad.org/
GNU General Public License v3.0
16 stars 13 forks source link

Password in credentials.json isn't properly escaped #161

Closed kuba-orlik closed 1 year ago

kuba-orlik commented 2 years ago

Describe the bug

If a users chooses a password that conains a ", then the credential.json is not a valid JSON and the app doesn't start

Context

Steps to reproduce

Expected behavior

The " char should be properly escaped

Logs

[2022-02-17 13:01:06.677] [INFO] settings - All relative paths will be interpreted relative to the identified Etherpad base dir: /var/www/etherpad_mypads
[2022-02-17 13:01:06.695] [INFO] settings - settings loaded from: /var/www/etherpad_mypads/settings.json
[2022-02-17 13:01:06.696] [ERROR] settings - There was an error processing your credentials file from /var/www/etherpad_mypads/credentials.json: Unexpected token Q in JSON at position 196
ericgaspar commented 2 years ago

https://github.com/YunoHost-Apps/etherpad_mypads_ynh/pull/163 should address this issue. to be tested