Use prebundled facilmap-server 3.1.0 release from NPM

YunoHost-Apps / facilmap_ynh

Facilmap package for YunoHost

https://facilmap.org/

GNU Affero General Public License v3.0

6 stars 3 forks source link

Use prebundled facilmap-server 3.1.0 release from NPM #2

Closed cdauth closed 3 years ago

cdauth commented 3 years ago

FacilMap 3.1.0 now supports running the published NPM packages directly (docs).

This Pull Request updates the package to install and run the facilmap-server NPM package directly, rather than downloading the source code from GitHub and bundling it by hand. The installation process should now be much faster and hopefully take less memory.

eauchat commented 3 years ago

Wow it's great, thanks for the many corrections and improvement on the repo, and also for fixing the still failing installation process. Really sorry for the delay in merging this Pull Request, I just saw it yesterday because I thought I was subscribed to this repo, but in fact not. Should be fixed now, so if you have any future changes I should be more reactive. Also, if you want to be able to edit the repo directly, you can ask access rights to the YunoHost-Apps group.

cdauth commented 3 years ago

I think it would be good to have access to this repository so that I can publish new versions in the future. Where exactly can I ask for access?

Does anything else need to be done in order to publish this?

eauchat commented 3 years ago

To have access to the repo, I think you should go to the matrix chat room of the yunohost apps contributors and explain it. I believe the chat room id is: #freenode_#yunohost-apps:matrix.org. In this page there's more ways to join that room if you prefer them.

To publish the package (=for people to be able to easily install facilmap):

this PR should be merged, so that it appears in the yunohost catalog
there should be no errors when testing the app in the CI, and the level of the app should be good enough (ideally 7) so that people feel confident that installing the app will not break their system

eauchat commented 3 years ago

Also, if you want maybe it would make sense that you are the maintainer of this package rather than me, since you'll follow the development process and be more able to adapt it to upgrades. Feel free to replace my name and email by yours in the manifest.json and check_process files.

cdauth commented 3 years ago

Yes, that makes sense to me. I will look into this in the next days and let you know about the progress.