Update to 6.1.11 and ZIP-files

philippstappert commented 5 months ago

Problem

Firefly updated to using zip files with the built files
Update to newest Firefly version

Solution

update to v6.1.11
change scripts and manifest to use new packaging format and new installation/upgrade commands

PR Status

[x] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

JC5 commented 4 months ago

!testme

alexAubin commented 4 months ago

!testme

yunohost-bot commented 4 months ago

Fingers crossed!

yunohost-bot commented 4 months ago

:worm:

alexAubin commented 4 months ago

Soooo it's almost working but for some reason composer complains about php 8.3 in "upgrade from old version" ... maybe we're not upgrading the composer file ... do we even need composer anymore since there's a vendor folder in the .zip ?

2024-04-23 18:38:43,962: DEBUG - + php8.3 /var/www/firefly-iii/composer.phar install --no-dev -d /var/www/firefly-iii --no-interaction --no-ansi
2024-04-23 18:38:44,061: DEBUG - Composer plugins have been disabled for safety in this non-interactive session. Set COMPOSER_ALLOW_SUPERUSER=1 if you want to allow plugins to run as root/super user.
2024-04-23 18:38:44,061: DEBUG - Do not run Composer as root/super user! See https://getcomposer.org/root for details
2024-04-23 18:38:44,142: DEBUG - > @php -r "if (!(getenv('DYNO'))===false){file_exists('.env') || copy('.deploy/heroku/.env.heroku', '.env');copy('.deploy/heroku/.locales', '.locales');}"
2024-04-23 18:38:44,177: DEBUG - Installing dependencies from lock file
2024-04-23 18:38:44,180: DEBUG - Verifying lock file contents can be installed on current platform.
2024-04-23 18:38:44,199: DEBUG - Your lock file does not contain a compatible set of packages. Please run composer update.
2024-04-23 18:38:44,200: DEBUG - 
2024-04-23 18:38:44,200: DEBUG -   Problem 1
2024-04-23 18:38:44,200: DEBUG -     - nette/schema is locked to version v1.2.2 and an update of this package was not requested.
2024-04-23 18:38:44,200: DEBUG -     - nette/schema v1.2.2 requires php >=7.1 <8.2 -> your php version (8.3.6) does not satisfy that requirement.
2024-04-23 18:38:44,200: DEBUG -   Problem 2
2024-04-23 18:38:44,200: DEBUG -     - nette/utils is locked to version v3.2.7 and an update of this package was not requested.
2024-04-23 18:38:44,201: DEBUG -     - nette/utils v3.2.7 requires php >=7.2 <8.2 -> your php version (8.3.6) does not satisfy that requirement.
2024-04-23 18:38:44,201: DEBUG -   Problem 3
2024-04-23 18:38:44,201: DEBUG -     - nette/schema v1.2.2 requires php >=7.1 <8.2 -> your php version (8.3.6) does not satisfy that requirement.
2024-04-23 18:38:44,201: DEBUG -     - league/config v1.1.1 requires nette/schema ^1.2 -> satisfiable by nette/schema[v1.2.2].
2024-04-23 18:38:44,201: DEBUG -     - league/config is locked to version v1.1.1 and an update of this package was not requested.
2024-04-23 18:38:44,201: DEBUG - 
2024-04-23 18:38:44,207: DEBUG - + ynh_die '--message=Unable to install core dependencies with Composer.'

alexAubin commented 4 months ago

!testme

yunohost-bot commented 4 months ago

:v:

yunohost-bot commented 4 months ago

:books:

alexAubin commented 4 months ago

Sooooo now we're getting during upgrade:

26137 INFO DEBUG - + php8.3 artisan migrate --seed
26137 INFO INFO - 'bootstrap/cache/*' wasn't deleted because it doesn't exist.
26137 INFO WARNING - PHP Fatal error:  Uncaught Error: Call to undefined function Illuminate\Filesystem\join_paths() in /var/www/firefly-iii/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:647

:thinking:

alexAubin commented 4 months ago

!testme

yunohost-bot commented 4 months ago

:stuck_out_tongue_winking_eye:

yunohost-bot commented 4 months ago

:books: :worm:

alexAubin commented 4 months ago

So hmmm yeah I'm stuck with this issue during upgrade :

32938 INFO INFO - [##########+++.......] > Upgrading database...
32938 INFO DEBUG - + pushd /var/www/firefly-iii
32938 INFO DEBUG - /var/www/firefly-iii /var/cache/yunohost/app_tmp_work_dirs/app_30zbwprr/app_folder/scripts
32938 INFO DEBUG - + php8.3 artisan migrate --seed
32938 INFO WARNING - PHP Fatal error:  Uncaught Error: Call to undefined function Illuminate\Filesystem\join_paths() in /var/www/firefly-iii/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:647
32938 INFO WARNING - Stack trace:
32939 INFO WARNING - #0 /var/www/firefly-iii/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(439): Illuminate\Foundation\Application->joinPaths()
32939 INFO WARNING - #1 /var/www/firefly-iii/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(413): Illuminate\Foundation\Application->basePath()
32939 INFO WARNING - #2 /var/www/firefly-iii/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(384): Illuminate\Foundation\Application->path()
32939 INFO WARNING - #3 /var/www/firefly-iii/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(372): Illuminate\Foundation\Application->bindPathsInContainer()
32939 INFO WARNING - #4 /var/www/firefly-iii/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(213): Illuminate\Foundation\Application->setBasePath()
32939 INFO WARNING - #5 /var/www/firefly-iii/bootstrap/app.php(69): Illuminate\Foundation\Application->__construct()
32939 INFO WARNING - #6 /var/www/firefly-iii/artisan(20): require_once('...')
32939 INFO WARNING - #7 {main}
32940 INFO WARNING -   thrown in /var/www/firefly-iii/vendor/laravel/framework/src/Illuminate/Foundation/Application.php on line 647

@JC5 : since you seem to be the main dev of Firefly-III, does this mean anything to you ? :grimacing: :sweat_smile:

alexAubin commented 4 months ago

!testme

yunohost-bot commented 4 months ago

Alrighty!