Testing - Githubissues

YunoHost-Apps / firefly-iii_ynh

Firefly III package for YunoHost

https://firefly-iii.org/

GNU General Public License v3.0

18 stars 10 forks source link

Testing #68

Closed ericgaspar closed 2 years ago

ericgaspar commented 2 years ago

Remove GIT

ericgaspar commented 2 years ago

!testme

yunohost-bot commented 2 years ago

May the CI gods be with you!

ericgaspar commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:stuck_out_tongue_winking_eye:

memo-567 commented 2 years ago

Tested on a productive installation, with an error message with a new transaction:

Error! Internal Firefly III Exception: Declaration of FireflyIII\Support\Request\ConvertsDataTypes::string(string $field): string must be compatible with Illuminate\Http\Request::string($key, $default = null)

This appears to be a Firefly bug, and not one from YunoHost? But please don't publish https://github.com/YunoHost-Apps/firefly-iii_ynh/pull/68 to master yet.

memo-567 commented 2 years ago

It might be a good idea to update to version 5.7.4 right away?

https://github.com/YunoHost-Apps/firefly-iii_ynh/pull/67/commits/22590bf96910ac96e26ca0fbed57d9bcc0767a6a https://github.com/YunoHost-Apps/firefly-iii_ynh/pull/67/commits/f00ed298cc51375738bf8bbbee21982d374308e6

ericgaspar commented 2 years ago

!testme

memo-567 commented 2 years ago

That was the reason. Works on local and productive installation now.

ericgaspar commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Meow :cat2: