search

YunoHost-Apps / flask_ynh

Flask template for YunoHost
6 stars 9 forks source link

[WiP] completely rewrite flask_ynh #10

Open h3ndrik opened 2 years ago

h3ndrik commented 2 years ago

I'd like to request some feedback, as this is my first larger YunoHost contribution.

Currently flask_ynh is outdated and broken. (And probably not maintained any more?)

As the configuration syntax changed significantly from what i see here, I started a complete rewrite, starting with example_ynh. I took some snippets from my_webapp_ynh and flask_ynh. (And did my best to test the new package on a develpoment machine.)

This should also solve a few issues and todo items. I'll put some more information into the README.

h3ndrik commented 2 years ago

!testme

alexAubin commented 2 years ago

Hey cheers !

Pinging @axolotle that may have some interest in this and is also working on flask-related app .. ( Maybe one day he'll finally release his work :sweat_smile: )

Feel free to poke us on the yunohost-apps chatroom as well

alexAubin commented 2 years ago

!testme

(You gotta be in the yunohost-apps org for this to work, I'll send you an invite ;))

yunohost-bot commented 2 years ago

:carousel_horse: Test Badge

Axolotle commented 2 years ago

Hi! As @alexAubin said, i'm working on a package that can install a distant flask app repository. It is designed a bit like my_webapp_ynh but relies on git for updating the flask app instead of SFTP.
I'm currently stuck at passing custom secret environment variables at install due to my poor knowledge of sed but the rest should be functional if you're interested (minus the upgrade that i haven't tested yet).

What's your plan for this package? I mean, how one will be able to customize the flask code?

h3ndrik commented 2 years ago

nice. i'll have a look when i get some time to spare. for now i'm just ssh'ing into my yunohost box and editing or copying things manually. i kind of paused working on this when i saw your (potentially more sophisticated) solution.

lapineige commented 10 months ago

🆙

What's the status of this ? :)

Could I try to convert this to app packaging format v2 ?

h3ndrik commented 10 months ago

I'm sorry. At this point you can consider this app abandoned. I simply don't have the time to maintain it. Unfortunately the other flask webapp mentioned above has also not seen any update since then. I'm not at the point to delete everything, but it's unlikely i'll resume working on it anytime soon.

lapineige commented 10 months ago

Ok, thank you for your feedback :)

lapineige commented 10 months ago

!testme

yunohost-bot commented 10 months ago

Alrighty! Test Badge

lapineige commented 10 months ago

I'll try to fix it, I'm sending a PR into yours ;)

lapineige commented 10 months ago

Once https://github.com/h3ndrik/flask_ynh/pull/1 is merged it should be working, and could be merged right away :smiley:

Gildas-GH commented 6 months ago

Any update ?

I can copy the pull request if h3ndrik cannot merge it.

I also saw that a FastAPI app was created, it could easily be adapted to run Flask apps as it's using Python and Gunicorn.

lapineige commented 6 months ago

No reply since this summer, let's go for it...