4.3 - Githubissues

YunoHost-Apps / framaforms_ynh

Create online webforms and surveys with Framaforms on YunoHost

https://framaforms.org/

GNU Affero General Public License v3.0

9 stars 6 forks source link

4.3 #52

Closed ericgaspar closed 2 years ago

ericgaspar commented 2 years ago

Problem

Description of why you made this PR

Solution

And how do you fix that problem

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ericgaspar commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Fingers crossed!

ericgaspar commented 2 years ago

!tastemetitus

yunohost-bot commented 2 years ago

Fingers crossed!

ericgaspar commented 2 years ago

The package seems to have changed a lot. The install process looks simpler : https://yakforms.org/pages/install.html

alexAubin commented 2 years ago

Alrighty, good news then :+1: :stuck_out_tongue:

ericgaspar commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Fingers crossed!

alexAubin commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:stuck_out_tongue_winking_eye:

ericgaspar commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:rocket:

ericgaspar commented 2 years ago

Shall we rename this repo Yakforms?

Tagadda commented 2 years ago

I guess we should. Does this PR handle migration from framaforms ?

ericgaspar commented 2 years ago

I guess we should. Does this PR handle migration from framaforms ?

No migration considered in this PR. Maybe we could create another repo named Yakforms alongside this one.

Tagadda commented 2 years ago

When bitwarden_rs was renamed to vaultwarden, repo was renamed, a command was added to the README for the migration. For the migration, we could use this helper in the upgrade script.

Tagadda commented 2 years ago

I did try this PR and after install I had to setup drupal in my browser (language, database, site info...). I think there was some stuff in the install script that ends the drupal setup automagically and it has been removed in this PR. French language pack was missing too.