YunoHost-Apps / freshrss_ynh

FreshRSS package for YunoHost
https://freshrss.org
GNU Affero General Public License v3.0
29 stars 20 forks source link

Various hooks inconsistencies results in mis-synchonization between freshrss accounts and who should exactly have access according to yunohost's permission #124

Open alexAubin opened 2 years ago

alexAubin commented 2 years ago

The post_user_create hook is called after each user creation, even if the corresponding freshrss.main permission is not allowed for all_users

Additionally, if the admin tweaks permission, the hook post_app_addaccess may be called and attempt to create an already-existing account.

AND if the permission gets removed, there's no post_remove_access to remove the account

Not sure what we want exactly .... I think we should either have (post_user_create, post_user_delete), OR (post_app_addaccess, post_app_removeaccess), but we should probably not have all 3 or 4 hooks...

lapineige commented 2 years ago

123 should (partly) fix that.

lapineige commented 1 year ago

Any recommendation for packaging v2 migration on that point ?