Various hooks inconsistencies results in mis-synchonization between freshrss accounts and who should exactly have access according to yunohost's permission #124
The post_user_create hook is called after each user creation, even if the corresponding freshrss.main permission is not allowed for all_users
Additionally, if the admin tweaks permission, the hook post_app_addaccess may be called and attempt to create an already-existing account.
AND if the permission gets removed, there's no post_remove_access to remove the account
Not sure what we want exactly .... I think we should either have (post_user_create, post_user_delete), OR (post_app_addaccess, post_app_removeaccess), but we should probably not have all 3 or 4 hooks...
The
post_user_create
hook is called after each user creation, even if the correspondingfreshrss.main
permission is not allowed forall_users
Additionally, if the admin tweaks permission, the hook
post_app_addaccess
may be called and attempt to create an already-existing account.AND if the permission gets removed, there's no
post_remove_access
to remove the accountNot sure what we want exactly .... I think we should either have
(post_user_create, post_user_delete)
, OR(post_app_addaccess, post_app_removeaccess)
, but we should probably not have all 3 or 4 hooks...